Automatically close form following other action in VBA

[JayGee1969]

I have created a button on my form that opens another form showing linked data. Having opened the second form I would like the first form to close, but cannot seem to get it to work. I have tried various different bits of code but none seem to work.

The code I have for the button at the moment (which does work insofar as opening the second form showing the correct record) is:

Private Sub Proceed_Click()
On Error GoTo Err_Proceed_Click

DoCmd.RunCommand acCmdSaveRecord

    Dim stDocName As String
    Dim stLinkCriteria As String

    stDocName = "frmCustOrd1"
    
    stLinkCriteria = "[OrderID]=" & Me![OrderID]
    DoCmd.OpenForm stDocName, , , stLinkCriteria
    
  
Exit_Proceed_Click:
    Exit Sub

Err_Proceed_Click:
    MsgBox Err.Description
    Resume Exit_Proceed_Click
    If Me.Dirty Then Me.Dirty = False
    
End Sub

Can anyone tell me what I need to add in and at what point to make the first form close?

[pbaldy]

DoCmd.Close

with the appropriate arguments. You'd put it after opening the other form.

[rpeare]

In the ON OPEN property of the form you open you can use code to check and see if the form you want to close is open as well, if it is, close it.

here's the code to check to see if a form is open

If SysCmd(acSysCmdGetObjectState, acForm, strFormName) <> conObjStateClosed Then
          If Forms(strFormName).CurrentView <> conDesignView Then
         'perform your close form operation here
         'this checks to see if the form is open and if it's in anything but design view
          End If
End If

[Missinglinq]

The Form the OP wants to Close is the one the code appears in and is being executed from, so it is obviously Open at the time! There is no need to check its state!

The most important of the 'appropriate arguments' Paul mentions is the actual name of the Form being Closed!

Private Sub Proceed_Click()
On Error GoTo Err_Proceed_Click

DoCmd.RunCommand acCmdSaveRecord

    Dim stDocName As String
    Dim stLinkCriteria As String

    stDocName = "frmCustOrd1"
    
    stLinkCriteria = "[OrderID]=" & Me![OrderID]
    DoCmd.OpenForm stDocName, , , stLinkCriteria
    
   DoCmd.Close acForm, "NameOfFirstForm"
  
Exit_Proceed_Click:
    Exit Sub

Err_Proceed_Click:
    MsgBox Err.Description
    Resume Exit_Proceed_Click
    If Me.Dirty Then Me.Dirty = False
    
End Sub

Replacing NameOfFirstForm with the actual name of the first Form.

DoCmd.Close, by itself would work without problems, if there was only one Form involved here, but in order to not confuse the Access Gnomes, because you have two Forms, here, you need to specifically state the Form to be Closed! And to be honest, it's a good practice to get into the habit of always explicitly naming the Form in question.

Linq ;0)>

[pbaldy]

God forbid someone might learn how to fish by having to look up the arguments themselves.

[rpeare]

I actually included the check on purpose in case the form can be opened from more than one source which I have had occasion to use a few times. So rather than trapping an unnecessary error it performs a quick check, does nothing if the form is open but closes it if it is.

[JayGee1969]

Sorry to have started an argument here but I really do appreciate this having been spelled out for me because I am very much a novice when it comes to VBA, and my next question would most certainly have been 'what are the appropriate arguments?'. I had already tried including DoCmd.Close into the coding and all I had succeeded in doing was closing the form the I wanted to open!

Thanks Missinglinq and rpeare, this has solved it for me.